Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of faulty binstubs #4235

Open
sigurdm opened this issue Apr 23, 2024 · 0 comments
Open

Improve handling of faulty binstubs #4235

sigurdm opened this issue Apr 23, 2024 · 0 comments
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-enhancement A request for a change that isn't a bug

Comments

@sigurdm
Copy link
Contributor

sigurdm commented Apr 23, 2024 •
edited

Related to #4225
In case of:

  • bad package name
  • Failing to parse properties
  • ....

We should degrade gracefully.
We could either:

  • assert that they are owned by someone else (emit diagnostic, leave binstub, but don't crash)
  • assert that they are broken (delete and recreate)

@jonasfj WDYT?
@sigurdm sigurdm added type-enhancement A request for a change that isn't a bug type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Apr 23, 2024
@sigurdm sigurdm mentioned this issue Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sigurdm