Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed resolution of global activate should indicate if package is discontinued #4130

Open
parlough opened this issue Jan 31, 2024 · 2 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@parlough
Copy link
Member

parlough commented Jan 31, 2024

There's been some confusion and reported issues by developers finding old references to use dart pub global activate for package:devtoools which was discontinued in favor of being bundled with the SDK.

Two recent examples of this resulting in confusion are flutter/devtools#7135, flutter/devtools#6550.

On recent SDK versions this fails due to incompatible SDK constraints, potentially misleading the user into thinking they have an issue. The error message should likely also indicate a package is discontinued and if it has a replacement.

I hope that will help avoid some of the confusion.

There's a separate issue for devtools though (likely for pub.dev), as there is no replacement package, so it might be nice if instead of a replacement, a link for more information could be configured instead. This might also help for packages and APIs that start outside of an SDK and later are included, if that ever happens.

@sigurdm
Copy link
Contributor

sigurdm commented Feb 1, 2024

Yeah it would be nice to show up-front that the package is discontinued.

A sad thing here is that if it managed to resolve it would be shown as discontinued in the resolution report.

There's a separate issue for devtools though (likely for pub.dev), as there is no replacement package, so it might be nice if instead of a replacement, a link for more information could be configured instead. This might also help for packages and APIs that start outside of an SDK and later are included, if that ever happens.

I think we decided against a custom deprecation message because we don't want package authors to be able to put arbitrary stuff in the terminal output. (could eg. be used for advertisement). Maybe we could link to the package page - where the README could explain more...

@sigurdm sigurdm added the type-enhancement A request for a change that isn't a bug label Feb 1, 2024
@sigurdm
Copy link
Contributor

sigurdm commented Feb 1, 2024

Related to dart-lang/pub-dev#2457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants