Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing analysis of macro test prevents other actions #3656

Open
eernstg opened this issue Mar 15, 2024 · 1 comment · May be fixed by #3660
Open

Failing analysis of macro test prevents other actions #3656

eernstg opened this issue Mar 15, 2024 · 1 comment · May be fixed by #3660
Labels
bug There is a mistake in the language specification or in an active document static-metaprogramming Issues related to static metaprogramming

Comments

@eernstg
Copy link
Member

eernstg commented Mar 15, 2024

The Dart CI log at https://github.com/dart-lang/language/actions/runs/8084567444/job/22725574044 shows a failure during the analyzer task dart analyze --fatal-infos ., in working/macros/example/benchmark/src/shared.dart:91:71 and elsewhere.

This causes other tasks to remain undone (in this case: no new PDF is created for the language specification when it is updated).

@jakemac53, would it be possible to fix the example, or somehow adjust the processing such that it doesn't block other tasks?
@eernstg eernstg added bug There is a mistake in the language specification or in an active document static-metaprogramming Issues related to static metaprogramming labels Mar 15, 2024
@eernstg eernstg mentioned this issue Mar 15, 2024
Open
@jakemac53
Copy link
Contributor

@jakemac53, would it be possible to fix the example, or somehow adjust the processing such that it doesn't block other tasks?

Yes we can allow it to fail, I can do that

@jakemac53 jakemac53 linked a pull request Mar 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug There is a mistake in the language specification or in an active document static-metaprogramming Issues related to static metaprogramming
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow macro analysis step to fail without stopping other jobs dart-lang/language
2 participants
@jakemac53 @eernstg