Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare_for_embedded.dart should use a fixed Cronet version #1100

Open
brianquinlan opened this issue Jan 2, 2024 · 7 comments
Open

prepare_for_embedded.dart should use a fixed Cronet version #1100

brianquinlan opened this issue Jan 2, 2024 · 7 comments
Assignees
Labels
package:cronet_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@brianquinlan
Copy link
Collaborator

prepare_for_embedded.dart updates build.gradle to use the latest version of Cronet.

This leads to the possible problem that the version of Cronet included in a release may not have been tested.

Instead, we should set an explicit version in prepare_for_embedded.dart.

@brianquinlan brianquinlan added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) package:cronet_http labels Jan 2, 2024
@brianquinlan brianquinlan self-assigned this Jan 2, 2024
@brianquinlan
Copy link
Collaborator Author

Any thoughts about this @AlexV525 ?

@AlexV525
Copy link
Contributor

AlexV525 commented Jan 2, 2024

It should be a corresponding version of the GMS version. Is the dependabot be able to do this?

@brianquinlan
Copy link
Collaborator Author

Do the GMS and embedded versions track identically? If so, we can just replace "com.google.android.gms:play-services-cronet" with "org.chromium.net:cronet-embedded" in prepare_for_embedded.dart and leave the version unchanged.

@AlexV525
Copy link
Contributor

AlexV525 commented Jan 3, 2024

Do the GMS and embedded versions track identically? If so, we can just replace "com.google.android.gms:play-services-cronet" with "org.chromium.net:cronet-embedded" in prepare_for_embedded.dart and leave the version unchanged.

Unfortunately no

@brianquinlan
Copy link
Collaborator Author

I don't know the answer regarding dependabot.

@AlexV525
Copy link
Contributor

AlexV525 commented Jan 3, 2024

Well that is just my idea. I'll do some investigation about it, before that we can find the correct version and apply it first.

@AlexV525
Copy link
Contributor

AlexV525 commented Jan 3, 2024

@brianquinlan Are you able contact owners of Cronet to know about version mapping between GMS and non-GMS versions?
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/components/cronet/OWNERS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:cronet_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants