Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tall] Preserve blank line between elements in list? #1469

Closed
munificent opened this issue May 6, 2024 · 0 comments · Fixed by #1483
Closed

[tall] Preserve blank line between elements in list? #1469

munificent opened this issue May 6, 2024 · 0 comments · Fixed by #1483
Labels
common easy safe tall Issues related to the new "tall" style (#1253)

Comments

@munificent
Copy link
Member

In the new tall style, it will currently preserve a blank line before a comment inside a list, as in:

stuff = [
  element,

  // blank line before this
  element,
];

But if there is a blank between elements with no comment, the blank line is discarded. So this:

stuff = [
  element,

  element,
];

Becomes:

stuff = [
  element,
  element,
];

Should we allow a discretionary newline in there and preserve it? The old style does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common easy safe tall Issues related to the new "tall" style (#1253)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant