Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we retrieve the samples from dart_services? #2857

Open
parlough opened this issue Feb 17, 2024 · 0 comments
Open

Should we retrieve the samples from dart_services? #2857

parlough opened this issue Feb 17, 2024 · 0 comments
Labels
P3 A lower priority bug or feature request type-question A question about expected behavior or functionality

Comments

@parlough
Copy link
Member

Right now if we want to update the samples, users will have to redownload the entire JS bundle. Plus the JS bundle includes the samples whether they will use them or not.

If we instead exposed them through a dart_services API, users would be able to use the cached JS bundle longer, the initial bundle would be smaller, and theoretically different channels could support different samples. This could be helpful for handling breaking changes, showcasing an experimental feature (extension types, macros, etc).

The one downside is extra implementation complexity that comes with this, but I thought I'd open the discussion for thoughts :)

@parlough parlough added type-question A question about expected behavior or functionality P3 A lower priority bug or feature request labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request type-question A question about expected behavior or functionality
Projects
None yet
Development

No branches or pull requests

1 participant