Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of co19 tests using legacy code #2643

Closed
sgrekhov opened this issue May 7, 2024 · 1 comment
Closed

Get rid of co19 tests using legacy code #2643

sgrekhov opened this issue May 7, 2024 · 1 comment
Assignees
@sgrekhov
Labels
area-test

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented May 7, 2024 •
edited

We need to get rid of the test if it's only about legacy code and not about unsound mode execution. If there is a need to obtain a value null with a non-nullable type T it should be possible to use a simple null as T. So it should be possible to simply change the legacy library to a more recent language version and then use things like null as T to do the job which was previously done by the legacy library
@sgrekhov sgrekhov self-assigned this May 7, 2024
@sgrekhov sgrekhov changed the title Get rid of co19 tests using legacu code Get rid of co19 tests using legacy code May 7, 2024
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 7, 2024
@sgrekhov
dart-lang#2643. Remove override checking tests in case a legacy class…
41f26b5 
… extending an opted-in class
eernstg pushed a commit that referenced this issue May 7, 2024
@sgrekhov
#2643. Remove override checking tests in case a legacy class extendin…
7a9814e 
…g an opted-in class (#2644)
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 7, 2024
@sgrekhov
dart-lang#2643. Remove legacy tests from LanguageFeatures/Generic-fun…
64c9f81 
…ctions-as-type-args
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 7, 2024
@sgrekhov
dart-lang#2643. Remove legacy tests from TypeSystem/type-normalization
adc47bd
eernstg pushed a commit that referenced this issue May 7, 2024
@sgrekhov
#2643. Remove legacy tests from TypeSystem/type-normalization (#2646)
9b8edc5
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 7, 2024
@sgrekhov
dart-lang#2643. Remove more legacy tests from LanguageFeatures/nnbd/w…
66a5783 
…eak/overriding
eernstg pushed a commit that referenced this issue May 7, 2024
@sgrekhov
#2643. Remove legacy tests from LanguageFeatures/Generic-functions-as…
615f218 
…-type-args (#2645)
eernstg pushed a commit that referenced this issue May 7, 2024
@sgrekhov
#2643. Remove more legacy tests from LanguageFeatures/nnbd/weak/overr…
0b00c5e 
…iding (#2647)
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 8, 2024
@sgrekhov
dart-lang#2643. Remove more legacy tests from LanguageFeatures/nnbd/w…
9f9a072 
…eak/overriding
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 8, 2024
@sgrekhov
dart-lang#2643. Remove some of 2.6 libraries, update/remove tests usi…
5378c19 
…ng them
@sgrekhov sgrekhov mentioned this issue May 8, 2024
Closed
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 8, 2024
@sgrekhov
dart-lang#2643. Remove tests checking exports from 2.6 libraries
972dd80
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 8, 2024
@sgrekhov
dart-lang#2643. Remove legacy types from subtyping tests
f116fc7
eernstg pushed a commit that referenced this issue May 8, 2024
@sgrekhov
#2643. Remove legacy types from subtyping tests (#2652)
8195243
eernstg pushed a commit that referenced this issue May 8, 2024
@sgrekhov
#2643. Remove tests checking exports from 2.6 libraries (#2651)
38c8e04
eernstg pushed a commit that referenced this issue May 8, 2024
@sgrekhov
#2643. Remove more legacy tests from LanguageFeatures/nnbd/weak/overr…
e07dc8f 
…iding (#2648)
eernstg pushed a commit that referenced this issue May 10, 2024
@sgrekhov
#2643. Remove some of 2.6 libraries, update/remove tests using them (#…
ee1696f 
…2650)

Remove some of 2.6 libraries, update/remove tests using them
@sgrekhov
Copy link
Contributor Author

Completed. The new roll with these changes is in progress https://dart-review.googlesource.com/c/sdk/+/365821

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 13, 2024
@sgrekhov
[co19] Roll co19 to 75e239c06f49c35a66595649e2172e16bad5f8b8
f969730 
2024-05-10 sgrekhov22@gmail.com dart-lang/co19#2641. Experimental flag renamed (dart-lang/co19#2655)
2024-05-10 sgrekhov22@gmail.com dart-lang/co19#2641. Add more test cases to the existing wildcard tests (dart-lang/co19#2654)
2024-05-10 sgrekhov22@gmail.com dart-lang/co19#2643. Remove some of 2.6 libraries, update/remove tests using them (dart-lang/co19#2650)
2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2643. Remove more legacy tests from LanguageFeatures/nnbd/weak/overriding (dart-lang/co19#2648)
2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2643. Remove tests checking exports from 2.6 libraries (dart-lang/co19#2651)
2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2643. Remove legacy types from subtyping tests (dart-lang/co19#2652)
2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2641. Add experimental flag to wildcards tests (dart-lang/co19#2653)
2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove more legacy tests from LanguageFeatures/nnbd/weak/overriding (dart-lang/co19#2647)
2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove legacy tests from LanguageFeatures/Generic-functions-as-type-args (dart-lang/co19#2645)
2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2631. Add tests checking access to local declaration named `_` (dart-lang/co19#2639)
2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove legacy tests from TypeSystem/type-normalization (dart-lang/co19#2646)
2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove override checking tests in case a legacy class extending an opted-in class (dart-lang/co19#2644)
2024-05-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2638. Add extension methods test for type aliases (dart-lang/co19#2640)
2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2142. Add tests checking type parameter vs representation variable name conflict (dart-lang/co19#2642)
2024-05-03 devoncarew@google.com blast_repo fixes (dart-lang/co19#2637)

Change-Id: I3f9f18065b555634b621100bdc375b40a75539cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365821
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
area-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgrekhov