Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_A04_t04 should not expect that the target of the symlink must exist on Windows #2291

Open
brianquinlan opened this issue Sep 28, 2023 · 2 comments
Open

create_A04_t04 should not expect that the target of the symlink must exist on Windows #2291

brianquinlan opened this issue Sep 28, 2023 · 2 comments
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@brianquinlan
Copy link
Contributor

This is the relevant code.

I've updated the docs in this PR.

I think that this test can just be deleted.
@sgrekhov sgrekhov self-assigned this Sep 28, 2023
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Sep 28, 2023
@sgrekhov
Copy link
Contributor

sgrekhov commented Sep 29, 2023 •
edited

According to the updated docs if we are create a Link to a not existing directory then this link should be created and be a file simlink. I'll change the tests accordingly.
If you don't mind I'll do it after the landing of the PR

@brianquinlan
Copy link
Contributor Author

Sure. The PR is documentation-only though.

sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 6, 2023
@sgrekhov
dart-lang#2291. Update Link.create() tests according to the documen…
6dc2779 
…tation
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 10, 2023
@sgrekhov
dart-lang#2291. Update Link.create() according to the documentation…
467628b 
…. Part 2
eernstg pushed a commit that referenced this issue Oct 10, 2023
@sgrekhov
#2291. Update Link.create() according to the documentation. Part 2 (#…
167b1d6 
…2301)
eernstg pushed a commit that referenced this issue Oct 11, 2023
@sgrekhov
#2291. Update Link.create() tests according to the documentation (#…
d04448a 
…2299)

Update `Link.create()` tests according to the documentation. Add more tests for calling create() with existing path.
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 12, 2023
@sgrekhov
dart-lang#2291. Update Link.createSync() according to the new docum…
c15435e 
…entation. Part 1
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 15, 2023
@sgrekhov
[co19] Roll co19 to 9d347fdf209cc343ca7fdf94a40deea88fa28896
bb28597 
2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2310. Fix new roll failures (dart-lang/co19#2311)
2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2306. Fix promoted instance type in not_promotable_A01_t04.dart (dart-lang/co19#2309)
2023-10-13 sgrekhov22@gmail.com Fixes dart-lang/co19#2307. Don't expect private fields promotion on static fields (dart-lang/co19#2308)
2023-10-11 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.create()` tests according to the documentation (dart-lang/co19#2299)
2023-10-11 sgrekhov22@gmail.com dart-lang/co19#2275. Add `noSuchMethod` tests. Part 3 (dart-lang/co19#2294)
2023-10-10 sgrekhov22@gmail.com dart-lang/co19#2275. Add `noSuchMethod` tests. Part 4 (dynamic semantics) (dart-lang/co19#2296)
2023-10-10 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.create()` according to the documentation. Part 2 (dart-lang/co19#2301)
2023-10-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2268. Fix LibTest/io/WebSocket/closeCode_A01_t02.dart to be not racy (dart-lang/co19#2302)
2023-10-09 sgrekhov22@gmail.com dart-lang/co19#1400. Add more tests for private fields promotion of extension types (dart-lang/co19#2300)

Change-Id: Ib34f392c8a2a0aaab8b7b0cb028f918ab2a3249f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330460
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 17, 2023
@sgrekhov
dart-lang#2291. Add more Link.createSync() tests. Part 2
2ae23ce
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 18, 2023
@sgrekhov
dart-lang#2291. Add more Link.createSync() tests
b1e9aef
eernstg pushed a commit that referenced this issue Oct 18, 2023
@sgrekhov
#2291. Add more Link.createSync() tests. Part 2 (#2316)
52b38e0 
Add more `Link.createSync()` tests. Part 2
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 24, 2023
@sgrekhov @athomas
[co19] Roll co19 to 5d40729f9d7e6c97d7449a7647e1aab6e76f1818
5315b1d 
2023-10-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2319. Fix roll failures (dart-lang/co19#2321)
2023-10-23 sgrekhov22@gmail.com dart-lang/co19#1400. [Extension types] Add more top types tests (dart-lang/co19#2322)
2023-10-18 sgrekhov22@gmail.com dart-lang/co19#1400. [Extension types] Add more superinterfaces tests (dart-lang/co19#2315)
2023-10-18 sgrekhov22@gmail.com dart-lang/co19#2291. Add more Link.createSync() tests. Part 2 (dart-lang/co19#2316)
2023-10-17 sgrekhov22@gmail.com Fixes dart-lang/co19#2304. Add more `Object` member tests (dart-lang/co19#2312)
2023-10-17 sgrekhov22@gmail.com dart-lang/co19#2313. Fix expected static type in upper_bound_A01_t05.dart (dart-lang/co19#2314)

Change-Id: Id5279b7bad5e45c7e8a5d2fa7cbffe49bd1b2093
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331860
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
eernstg pushed a commit that referenced this issue Oct 25, 2023
@sgrekhov
#2291. Update Link.createSync() according to the new documentation.…
802b5ce 
… Part 1 (#2305)

Update `Link.createSync()` according to the new documentation. Part 1
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 27, 2023
@sgrekhov
[co19] Roll co19 to 3011a2e78f407ba3f9a3cf543fe17f5e8f2cc294
db3fddd 
2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2329. Fix FileSystemEntity.type() on Windows (dart-lang/co19#2332)
2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2330. Remove obsolete error expectation (dart-lang/co19#2331)
2023-10-25 sgrekhov22@gmail.com Fixes dart-lang/co19#2317. Add tests for extension type type parameters in non-covariant position (dart-lang/co19#2318)
2023-10-25 sgrekhov22@gmail.com dart-lang/co19#2291. Update `Link.createSync()` according to the new documentation. Part 1 (dart-lang/co19#2305)
2023-10-24 sgrekhov22@gmail.com dart-lang/co19#2313. [Extension types] Add nullability tests (dart-lang/co19#2324)
2023-10-24 sgrekhov22@gmail.com dart-lang/co19#2323. Delete obsolete test (dart-lang/co19#2327)
2023-10-24 sgrekhov22@gmail.com Fixes dart-lang/co19#2323. Don't test datagram size more than 65503 (dart-lang/co19#2325)

Change-Id: I23b57a58b5cd6452e2beb923dd8cde6fd587f051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332206
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @brianquinlan