-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http-max-request-size is not applied to actor response body size #7674
Comments
What SDK are you using to invoke the actor? |
I'm using the .NET SDK to both invoke and host the actor. But as noted above, the error is logged in the sidecar, which suggested to me it was not an SDK issue. |
Just to add some more information...I've tested the scenario again, this time just using curl. When I call the actor via it's sidecar, the response is successful.
However, when I call the actor, via the 'client' sidecar, I get the error:
but again, I do see this in the client's sidecar logs:
Hopefully this helps identify the issue |
That does help a lot, thanks |
In what area(s)?
/area runtime
What version of Dapr?
1.13.1
Expected Behavior
An actor should be able to return a response body with a payload up to the size specified by the http-max-request-size argument.
Actual Behavior
An error occurs when an actor response body is > 4 MB irregardless of the value of the http-max-request-size argument.
Note that in my testing, the issue is only with an actor response body....not when sending a large request body.
Steps to Reproduce the Problem
To reproduce the problem, I've cloned the AspireWithDapr project and added an WeatherActor which returns ~ 8 MB of weather forecasts. I've also configured the normal API to also return 8 MB.
I've added the
--dapr-http-max-request-size 16
parameter to the dapr sidecar, and I can see it is applied in the sidecar logs,What I'm seeing is that both the service invocation and actor return an error when the
--dapr-http-max-request-size
is not specified.However, when it is set to 16, the service invocation endpoint succeeds, but the actor endpoint returns this error:
I also added a method to the actor to accept an array of weather forecasts, and it seems I can send more than 4 MB request to the actor. So the issue is only when returning a response.
Release Note
RELEASE NOTE:
http-max-request-size argument now applies to actor response body message size.
The text was updated successfully, but these errors were encountered: