Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LANGUAGE not respected #104

Open
nurtext opened this issue Nov 30, 2023 · 4 comments
Open

LANGUAGE not respected #104

nurtext opened this issue Nov 30, 2023 · 4 comments

Comments

@nurtext
Copy link

nurtext commented Nov 30, 2023

Hi,

I've tried setting the env var LANGUAGE to de and restarted the docke container, but nothing happens. The displayed language is still en. I also tried with various other values (as listed in https://github.com/daledavies/jump/tree/main/jumpapp/translations) but no luck so far.

Config as follows:

version: '3'

services:
  jump:
    image: daledavies/jump:v1.3.2
    container_name: jump
    restart: always
    ports:
      - "8080:8080"
    volumes:
      - /mnt/data/jump/backgrounds:/backgrounds
      - /mnt/data/jump/favicon:/favicon
      - /mnt/data/jump/search:/search
      - /mnt/data/jump/sites:/sites
    environment:
      LANGUAGE: 'de'

Debug from within container:

$ docker compose exec jump sh
$ env | grep -i lang
LANGUAGE=de

Is there anything that I'm missing or isn't it working properly?

@mbl-35
Copy link

mbl-35 commented Apr 6, 2024

Hi @nurtext .. I think that's because lang was not supported with v1.3.2..

From code inspection: 57 files changed since last release v1.3.2 :
################################
Dockerfile
Dockerfile-xdebug
README.md
docker/entrypoint.sh
docker/nginx.conf
jumpapp/.jump-version
jumpapp/assets/css/debugger.css
jumpapp/assets/css/src/_sites.scss
jumpapp/assets/css/src/index.scss
jumpapp/assets/css/styles.16a6188fbec500ac7a6a.min.css
jumpapp/assets/css/styles.1ca83f0b531ebb5db978.min.css
jumpapp/assets/js/index.b7edc402416d63e189f5.min.js
jumpapp/assets/js/src/classes/Greeting.js
jumpapp/assets/js/src/classes/Main.js
jumpapp/assets/js/src/classes/SearchSuggestions.js
jumpapp/classes/API/AbstractAPI.php
jumpapp/classes/API/Icon.php
jumpapp/classes/API/Unsplash.php
jumpapp/classes/API/Weather.php
jumpapp/classes/Cache.php
jumpapp/classes/Config.php
jumpapp/classes/Debugger/ErrorLogger.php
jumpapp/classes/Debugger/JumpConfigPanel.php
jumpapp/classes/Debugger/JumpVersionPanel.php
jumpapp/classes/Language.php
jumpapp/classes/Main.php
jumpapp/classes/Pages/AbstractPage.php
jumpapp/classes/Pages/ErrorPage.php
jumpapp/classes/Pages/HomePage.php
jumpapp/classes/Pages/TagPage.php
jumpapp/classes/SearchEngines.php
jumpapp/classes/Site.php
jumpapp/classes/Sites.php
jumpapp/classes/Status.php
jumpapp/classes/Unsplash.php
jumpapp/cli/cacheunsplash.php
jumpapp/composer.json
jumpapp/composer.lock
jumpapp/config.php
jumpapp/sites/sites.json
jumpapp/templates/errorpage.mustache
jumpapp/templates/errorpage.php
jumpapp/templates/footer.mustache
jumpapp/templates/header.mustache
jumpapp/templates/partials/cssbundle.mustache
jumpapp/templates/partials/jsbundle.mustache
jumpapp/templates/sites.mustache
jumpapp/translations/cs.json
jumpapp/translations/de.json
jumpapp/translations/en-gb.json
jumpapp/translations/es.json
jumpapp/translations/lt.json
jumpapp/translations/nl.js
jumpapp/translations/pt.json
jumpapp/translations/ru.json
jumpapp/translations/ua.json
package-lock.json

Hope that @daledavies will publish a new container version soon on dockerhub to get this main feature... :)

@daledavies
Copy link
Owner

Working on the docker release at the moment. Just adding documentation first :)

@daledavies
Copy link
Owner

Done! You can get the new release by pulling the latest or v1.4.0 tags from Docker Hub.

Please let me know how you get on :)

@mbl-35
Copy link

mbl-35 commented May 24, 2024

Hello DaleDavies, tested today with tag v1.4.0.. working:

$ /test-daledavies-jump$ docker exec -it test-daledavies-jump-web-1 sh
/var/www/html # env
LANGUAGE=fr

Thanks

`/var/www/html/translations/de.json is also in conatiner..
You can close this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants