Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling the edge lines with line-outline properties (border) #3243

Closed
3 of 4 tasks
xkdgo opened this issue May 15, 2024 · 0 comments
Closed
3 of 4 tasks

Styling the edge lines with line-outline properties (border) #3243

xkdgo opened this issue May 15, 2024 · 0 comments
Milestone

Comments

@xkdgo
Copy link
Contributor

xkdgo commented May 15, 2024

Description of new feature

In addition to existing overlays/underlays add new properties to edges
line-outline-width and line-outline-color

Those properties are add new border visualisation of edge when line-outline-width > 0
line-ouline-dashed

Motivation for new feature

This feature is usable when use library for network weathermap. There was a dialogue about this feature.
When there is zero traffic between nodes it can be shown in white, but this is impossible now when the background is also white.
Underlay can resolve this problem only when line is not dashed.
When the feature is implemented , overlay/underlay can be used when highlighting a line.
In example below

      "style": {
          // existed properties
          "width": 3,
          "line-color": "white",
          "underlay-opacity": "0.3",
          "underlay-color": "red",
          "underlay-padding": "3px",
          "line-style": "dashed",
          "line-dash-pattern": [15, 15],
          
          // new feature proposal
          "line-outline-width": 2, // default 0 mean switched off
          "line-outline-color": "#000" // default "#000"
      }

visualisation will be
line-ouline-dashed-with-undelay

For reviewers

Reviewers should ensure that the following tasks are carried out for incorporated issues:

  • Ensure that the reporter has adequately described their idea. If not, elicit more information about the use case. You should iteratively build a spec together.
  • Ensure that the issue is a good fit for the core library. Some things are best done in extensions (e.g. UI-related features that aren't style-related). Some things are best done by app authors themselves -- instead of in Cytoscape libraries.
  • The issue has been associated with a corresponding milestone.
  • The commits have been incorporated into the unstable branch via pull request. The corresponding pull request is cross-referenced.
@xkdgo xkdgo mentioned this issue May 16, 2024
7 tasks
@mikekucera mikekucera added this to the 3.30.0 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants