Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History Driver replace problem #989

Open
FbN opened this issue May 20, 2022 · 3 comments · May be fixed by #993
Open

History Driver replace problem #989

FbN opened this issue May 20, 2022 · 3 comments · May be fixed by #993

Comments

@FbN
Copy link

FbN commented May 20, 2022

Having issues after upgrading history driver to latest version (state not replaced).

Looking to code I see that now input is passed as object to underling history lib

if (input.type === 'replace') {
      history.replace({...input});
}

But remix-run/history still require separate params:

  /**
   * Replaces the current location in the history stack with a new one.  The
   * location that was replaced will no longer be available.
   *
   * @param to - The new URL
   * @param state - Data to associate with the new location
   *
   * @see https://github.com/remix-run/history/tree/main/docs/api-reference.md#history.replace
   */
  replace(to: To, state?: any): void;
@jvanbruegge
Copy link
Member

Could you open a PR for that?

ZZITE added a commit to ZZITE/cyclejs that referenced this issue Jul 23, 2022
@ZZITE ZZITE linked a pull request Jul 23, 2022 that will close this issue
3 tasks
@ZZITE
Copy link

ZZITE commented Jul 23, 2022

I opened a PR to fix this #993

@ryota-ka
Copy link
Contributor

@staltz @jvanbruegge Could you please review the PR?
I also ran into the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants