Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: remove XpressProblem class (keep XPRESS solver support!) #2214

Closed
rileyjmurray opened this issue Aug 17, 2023 · 3 comments
Closed

Comments

@rileyjmurray
Copy link
Collaborator

We have a class called XpressProblem defined in cvxpy/problems/xpress_problem.py. This class is basically dead code. From what I can tell, it's only used in one place, and that place is an odd example: examples/advanced/xpress_example.py.

I'd like for CVXPY 1.4 to mark this class as deprecated with a notice that it's slated for removal in CVXPY 1.5. I know that this could in principle be a breaking change, but I seriously doubt that it will affect anyone.

@cvxpy/maintainers, what do you think?

@SteveDiamond
Copy link
Collaborator

Sounds good to me.

@phschiele
Copy link
Collaborator

@rileyjmurray agree with your proposal and playing it safe. While it could be breaking, it is also not part of the public API.

@rileyjmurray
Copy link
Collaborator Author

rileyjmurray commented Nov 4, 2023

... we didn't get around to doing this, did we?

Ping @phschiele and @SteveDiamond

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants