Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph not unloading? #131

Open
daliborfilus opened this issue Apr 28, 2022 · 0 comments · May be fixed by #132
Open

Graph not unloading? #131

daliborfilus opened this issue Apr 28, 2022 · 0 comments · May be fixed by #132

Comments

@daliborfilus
Copy link

Hello, thank you for this react component. I have an issue, where I have this graph component in a functional (pure) react component inside a Material UI tab. Then I load a 300-node graph, which is rendering somewhat slowly, but consistently. But when I switch tabs, the browser remains laggy. When I switch tabs back to the graph, the graph is properly re-drawn, but is now much slower. Switching tabs back and forth just increases the lag.

Looking at the code, it seems to me that you don't unload the visjs network graph on component dismount?

daliborfilus added a commit to daliborfilus/react-graph-vis that referenced this issue Apr 28, 2022
@daliborfilus daliborfilus linked a pull request Apr 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant