Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeasureReport missing id #396

Open
rob-reynolds opened this issue Dec 28, 2023 · 3 comments
Open

MeasureReport missing id #396

rob-reynolds opened this issue Dec 28, 2023 · 3 comments
Labels
bug Something isn't working dQM

Comments

@rob-reynolds
Copy link

rob-reynolds commented Dec 28, 2023

IS:
MeasureReport does not have an id.

SHOULD BE:
MeasureReport should include an id. In addition to other considerations, you cannot PUT a MeasureReport without one, and adding an MR to a Bundle using the CQFTooling gets messed up.

REPRO:
Run $evaluate-measure (all types). See comments for an example and/or files to repro (although a simpler repro is any MR).

NOTE:
Oddly, the MR in a $care-gaps result has an id. See comments for an example and/or files to repro (although a simpler repro is any Care Gap Report).

@rob-reynolds rob-reynolds added the bug Something isn't working label Dec 28, 2023
@rob-reynolds
Copy link
Author

rob-reynolds commented Dec 29, 2023

Example of MR generated without an id:

example measure report.json

The example can be repro'd by:

POST [cc-cds-examples-bundle.json](https://github.com/alphora/demo-content-r4/blob/cpg-format/bundles/cc-cds-examples-bundle.json)

POST [cc-cds-patient-data-bundle.json](https://github.com/alphora/demo-content-r4/blob/cpg-format/bundles/cc-cds-patient-data-bundle.json)

POST [cc-cds-resources-bundle.json](https://github.com/alphora/demo-content-r4/blob/cpg-format/bundles/cc-cds-resources-bundle.json)

GET http://localhost:8000/Measure/ColorectalCancerScreeningsFHIR/$evaluate-measure?subject=Patient/nocoverageconcern-sedconcern-nosigcomp&periodStart=2024-01-01&periodEnd=2024-06-01&type=individual

@rob-reynolds
Copy link
Author

rob-reynolds commented Dec 29, 2023

Example of Care Gap Report generated with an id:

example care gaps report.json

The example can be repro'd by:
(the first three POSTS are the same as the repro for the MR example, so if you've already run them you can just run the GET)

POST [cc-cds-examples-bundle.json](https://github.com/alphora/demo-content-r4/blob/cpg-format/bundles/cc-cds-examples-bundle.json)

POST [cc-cds-patient-data-bundle.json](https://github.com/alphora/demo-content-r4/blob/cpg-format/bundles/cc-cds-patient-data-bundle.json)

POST [cc-cds-resources-bundle.json](https://github.com/alphora/demo-content-r4/blob/cpg-format/bundles/cc-cds-resources-bundle.json)

GET http://localhost:8000/Measure/$care-gaps?subject=Patient/nocoverageconcern-sedconcern-sigcomp&periodStart=2024-01-01&periodEnd=2024-06-01&status=open-gap&measureId=ColorectalCancerScreeningsFHIR

@JPercival
Copy link
Contributor

JPercival commented Jan 12, 2024

Id is an internal system identifier, the requirements for which vary from system to system. We have no way to know the specific requirements for Ids on any given system, so any arbitrary Id generation strategy we come up with will be wrong for someone. So, I disagree that we ought to generate an Id. Rather, we should explain how to save a MeasureReport without an Id. Which is to use POST rather than PUT. Alternatively, the integrators of this library are able to modify the returned MeasureReport and add an id that's appropriate for their platform if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dQM
Projects
None yet
Development

No branches or pull requests

3 participants