Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] bidsCopyInputFolder doesn't follow output directory #1205

Open
4 of 9 tasks
JacMatu opened this issue Feb 16, 2024 · 1 comment
Open
4 of 9 tasks

[BUG] bidsCopyInputFolder doesn't follow output directory #1205

JacMatu opened this issue Feb 16, 2024 · 1 comment
Labels
bug 🐛 Something isn't working

Comments

@JacMatu
Copy link

JacMatu commented Feb 16, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Operating system

  • Linux
  • Mac
  • Windows

Operating system version

No response

SPM 12 version

  • 7771
  • 7487
  • 7219

Platform

  • MATLAB
  • Octave

Platform version

  • MATLAB 2019a
  • Octave 4.2.2

bidspm version

v3.1.0

bidspm branch / commit number

No response

Expected Behavior

I'm running
bidsCopyInputFolder(opt,'unzip', true)
with intention to copy and unzip data from raw to derivatives/bidspm-preproc for further processing (generating T1 maps)

dirs are set up like this:
opt.dir.input = fullfile(root_dir, 'inputs', 'raw'); opt.dir.derivatives= fullfile(root_dir,'outputs','derivatives'); opt.dir.output = fullfile(root_dir,'outputs','derivatives', 'bidspm-preproc');

with my expectancy to copy and unzip stuffs from opt.dir.input to opt.dir.output, e.g. to have an unzipped files in derivatives/bidspm-preproc

BIDS stats model

No response

Current Behavior & Error message

Instead, bidsCopyInputFolder creates a new dir in derivatives, called simply bidspm, ignoring my target output to store unzipped data.

Anything else?

can it be caused by

    bids.copy_to_derivative(BIDS, ...
                            'pipeline_name', pipeline_name, ...
                            'out_path', fullfile(opt.dir.output, '..'), ...
                            'filter', filter, ...
                            'unzip', unzip, ...
                            'force', force, ...
                            'skip_dep', skip_dependencies, ...
                            'use_schema', use_schema, ...
                            'verbose', opt.verbosity > 0, ...
                            'tolerant', TOLERANT);

I see 'out_path', fullfile(opt.dir.output, '..') to skip one dir above the output.
When I changed it to 'out_path', opt.dir.output files were copied and unzipped to `derivatives/bidspm-preproc/bidspm'

This never happened when I used bidspm workflows like preproc (that also include copying and unzipping data), just when I want to use that function in isolation to prepare for things that are not covered by main workflows (T1 map generation, data upsampling, denoising with presurfer, etc.)

@JacMatu JacMatu added the bug 🐛 Something isn't working label Feb 16, 2024
Copy link

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant