Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to drop -Werror for tests/configs pulling external APIs/frameworks #783

Open
hfp opened this issue Apr 22, 2024 · 2 comments
Open

Comments

@hfp
Copy link
Member

hfp commented Apr 22, 2024

As we pull latest bits/dependencies into tests, our CI is prone to break automatically. For example, some recent ROCm deprecation seems to cause warnings (turned into errors). This may be wanted but if not, -Werror may be disabled for certain configs.

In file included from /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:13:
/__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp: In function ‘int c_dbcsr_acc_init()’:
/__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:30:40: error: ‘hipError_t hipDevicePrimaryCtxRetain(ihipCtx_t**, hipDevice_t)’ is deprecated: This API is marked as deprecated and may not be supported in future releases. For more details please refer https://github.com/ROCm/HIP/blob/develop/docs/reference/deprecated_api_list.md [-Werror=deprecated-declarations]
30 | ACC_DRV_CALL(DevicePrimaryCtxRetain, (&ctx, acc_device));
/__w/dbcsr/dbcsr/src/acc/cuda_hip/../hip/acc_hip.h:33:35: note: in definition of macro ‘HIP_API_CALL’
33 | hipError_t result = ACC(func) args;
| ^~~~
/__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:30:3: note: in expansion of macro ‘ACC_DRV_CALL’
30 | ACC_DRV_CALL(DevicePrimaryCtxRetain, (&ctx, acc_device));
| ^~~~~~~~~~~~
In file included from /opt/rocm-6.1.0/include/hip/hip_runtime.h:70,
from /__w/dbcsr/dbcsr/src/acc/cuda_hip/../hip/acc_hip.h:13,
from /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:13:
/opt/rocm-6.1.0/include/hip/hip_runtime_api.h:5128:12: note: declared here
5128 | hipError_t hipDevicePrimaryCtxRetain(hipCtx_t* pctx, hipDevice_t dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:13:
/__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp: In function ‘int c_dbcsr_acc_finalize()’:
/__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:44:41: error: ‘hipError_t hipDevicePrimaryCtxRelease(hipDevice_t)’ is deprecated: This API is marked as deprecated and may not be supported in future releases. For more details please refer https://github.com/ROCm/HIP/blob/develop/docs/reference/deprecated_api_list.md [-Werror=deprecated-declarations]
44 | ACC_DRV_CALL(DevicePrimaryCtxRelease, (acc_device));
/__w/dbcsr/dbcsr/src/acc/cuda_hip/../hip/acc_hip.h:33:35: note: in definition of macro ‘HIP_API_CALL’
33 | hipError_t result = ACC(func) args;
| ^~~~
/__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:44:3: note: in expansion of macro ‘ACC_DRV_CALL’
44 | ACC_DRV_CALL(DevicePrimaryCtxRelease, (acc_device));
| ^~~~~~~~~~~~
In file included from /opt/rocm-6.1.0/include/hip/hip_runtime.h:70,
from /__w/dbcsr/dbcsr/src/acc/cuda_hip/../hip/acc_hip.h:13,
from /__w/dbcsr/dbcsr/src/acc/cuda_hip/acc_init.cpp:13:
/opt/rocm-6.1.0/include/hip/hip_runtime_api.h:5112:12: note: declared here
5112 | hipError_t hipDevicePrimaryCtxRelease(hipDevice_t dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

@alazzaro
Copy link
Member

So, the problem here is that we use FROM rocm/dev-ubuntu-22.04:latest which moved from ROCM 6.0.1 to 6.1.0 and now some HIP functions are deprecated...
I wonder if we should set a tag for ROCM (up to 6.0.2 for example). I don't think we should remove -Werror...
ROCM 6.1 introduced a long list of deprecated functions, however I'm not sure how we should update them... Maybe @gsitaram can help?

@hfp I would say, for the moment, please ignore this problem.

@alazzaro
Copy link
Member

alazzaro commented Apr 22, 2024

@hfp , you can also add -Wno-error=deprecated-declarations for the moment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants