Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug : attributeTag returns undefined if attribut has more then one reference #253

Open
Ragnar-Oock opened this issue Jun 19, 2023 · 0 comments

Comments

@Ragnar-Oock
Copy link

Some Data Elements with VR AT have a Value Multiplicity of 1-n, meaning they can have more than one value stored inside. However, the code and the comment on the function hint at an undefined return if the value length is strictly different then 4 bytes long.

code in question :

attributeTag (tag) {

examples of attribute of VR AT with a VM of 1-n :
(0028,0009) Frame Increment Pointer
(0028,000A) Frame Dimension Pointer

possible solutions :

  • change the signature of the function to accept an index parameter like the other parse function of this module and return the first value by default to keep retro compatibility
  • change the behavior of the function to return an array of values corresponding to all the attribute tags liste in the element (breaking changes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant