Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use guarded/better Notifications code. #387

Open
ewlsh opened this issue Sep 12, 2020 · 1 comment
Open

Use guarded/better Notifications code. #387

ewlsh opened this issue Sep 12, 2020 · 1 comment
Labels

Comments

@ewlsh
Copy link
Member

ewlsh commented Sep 12, 2020

Don't rely on a try-catch pattern - it obfuscates required checks.

re: mobile iOS doesn't support Notifications

@ewlsh
Copy link
Member Author

ewlsh commented Sep 12, 2020

Let's write an ESLint rule to forbid the Notification global unless we specifically allow it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants