Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canEnablePIP is not defined when using 'react-player/file' #1714

Open
alessandroliveri opened this issue Nov 20, 2023 · 0 comments
Open

canEnablePIP is not defined when using 'react-player/file' #1714

alessandroliveri opened this issue Nov 20, 2023 · 0 comments

Comments

@alessandroliveri
Copy link

Current Behavior

FilePlayer.canEnablePIP returns always false even if the feature is supported because it seems to be undefined here

if (Player.canEnablePIP && Player.canEnablePIP(url)) {

Expected Behavior

FilePlayer.canEnablePIP returns true when it should

Steps to Reproduce

  1. use import FilePlayer from 'react-player/file';
  2. call FilePlayer.canEnablePIP

Environment

  • Browser: Chrome, Safari
  • Operating system: Mac OS 14.1

Other Information

using ReactPlayer.canEnablePIP by importing it from react-player works as expected

@alessandroliveri alessandroliveri changed the title canEnablePIP is not defined when I use 'react-player/file' canEnablePIP is not defined when using 'react-player/file' Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant