Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version upgrade for ckan2.9 #45

Open
liquanyong305 opened this issue Jan 18, 2022 · 7 comments
Open

version upgrade for ckan2.9 #45

liquanyong305 opened this issue Jan 18, 2022 · 7 comments

Comments

@liquanyong305
Copy link

Hello everyone

We use Ckan2.9.4 to develop our project, but ckan-oauth2 only supports 2.7 or 2.8.
Do you have any plans to upgrade version for ckan2.9?

Thanks a lot for the work you have done on this plugin.

@liquanyong305 liquanyong305 changed the title version update for ckan2.9 version upgrade for ckan2.9 Jan 18, 2022
@frafra
Copy link

frafra commented Feb 16, 2022

Please test and give feedback to #46.

@Nisha1293
Copy link

Nisha1293 commented Aug 4, 2023

Hi @frafra,

I tested #46 on latest CKAN v2.9.9 and v2.10.1 but I am getting below error:
AttributeError
AttributeError: 'Request' object has no attribute 'GET'

Any suggestion on this? Does any other PR exist, or are the latest changes in another branch?"

@frafra
Copy link

frafra commented Aug 6, 2023

@nisha-nec See #42.

@Nisha1293
Copy link

Nisha1293 commented Sep 1, 2023

Hi @frafra
Thanks for the information.
I tried but the code changes as per the CKANv2.9.x.
I tested it on CKANv2.10.1, in this version, Authentication logic to use [Flask-login] instead of repoze.who.
Do you have updated code. ?
Any help will be appreciated.

@frafra
Copy link

frafra commented Sep 4, 2023

@Nisha1293
Copy link

Nisha1293 commented Sep 4, 2023

@frafra yes, in 2.9 it will work fine, but from CKAN 2.10, Repoze has been replaced for flask-login and this includes several changes:

  1. Login is now handled by user_login function (instead of set_repoze_user)
  2. auth_tkt cookie has been deprecated since it was being set by Repoze

@frafra
Copy link

frafra commented Sep 4, 2023

@nisha-nec Sorry for the misunderstanding. As you can see, no one seems interested in supporting OAuth2 on newer CKAN. Someone needs to pick up the PR for 2.9, fix the remaining issues, then merge the PR (or fork the repository), and then focus on the 2.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants