Correct display of time during data-request creation , closing of data-request and while commenting #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changing the existing datetime method from now -> utcnow
|
Please, change the destination branch to “develop” so the CI system can run the tests before merging :)
|
|
Hi @aitormagan, have changed the destination branch to develop and raised at URL : #45. |
|
Closed as changes are merged in #45 |
mutantsan
pushed a commit
to mutantsan/ckanext-datarequests
that referenced
this pull request
Oct 14, 2022
….2.0 Bump xlrd from 1.0.0 to 1.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
The fix includes below scenarios:
The correct time when a data request is created.
-> it will now show "Just now " instead of "-1 days ago " earlier.
The correct time when a data request is closed
The correct time while commenting on the respective data-request as shown below
Thus, this fix has also been resolved in this PR.