Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] On changing the language on review page, sentences from previous language appear even after refresh #4477

Open
chasingdragonflies opened this issue May 13, 2024 · 3 comments
Assignees

Comments

@chasingdragonflies
Copy link
Contributor

Describe the bug
I was reviewing the sentences on review page in hindi language. I went to switch the language from the menu so i could review sentences written in english. However the review cards did not change/update when i changed the language.

To Reproduce
Steps to reproduce the behavior:

  1. Log in to your commonvoice account
  2. Open the review page (lets say, under english)
  3. Review a sentence. Then go to the hamburger menu and change the language directly where it says "english" to any language (say russian)
  4. The cards on the review page will not update according to the language that is currently selected.

Expected behavior
The review sentence cards must update after the language has been changed. But they only seem to update after clicking on the other tabs (speak, listen, write)

Screenshots
Screenshot_20240510-110812_Firefox

Desktop or Mobile (please complete the following information):

  • OS: android
  • Browser: Firefox
  • Version: 125.3.0

Additional Hardware (were you using headphones, an external speaker or an external microphone?):

  • N/A
@chasingdragonflies chasingdragonflies changed the title [BUG] On changing the language on review page, the previous language sentence appear even after refresh [BUG] On changing the language on review page, sentences from pevious language appear even after refresh May 13, 2024
@jessicarose
Copy link
Collaborator

Thanks so much for flagging this, a quick test on my side also results in the described behaviour on both mobile and desktop. This is likely a very frustrating bug for contributors to encounter, so it's really amazing of you to have found and raised this for us. Thank you again.

I'll work to get this triaged with the team.

@jessicarose jessicarose self-assigned this May 13, 2024
@chasingdragonflies chasingdragonflies changed the title [BUG] On changing the language on review page, sentences from pevious language appear even after refresh [BUG] On changing the language on review page, sentences from previous language appear even after refresh May 14, 2024
@HarikalarKutusu
Copy link
Contributor

I think #4472 and this one are tightly related.

@chasingdragonflies
Copy link
Contributor Author

This does seem related to localStorage. I guess purging sentences from localstorage on change of language should fix it. But that's just my guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants