new cabana feedback #26091
Replies: 89 comments 206 replies
-
Performance is already great. Some miscellaneous notes while playing around with it:
bugs
|
Beta Was this translation helpful? Give feedback.
-
I'm making use of this while finishing #24012, and I just want to say I'm incredibly impressed by @deanlee's work so far. In some respects, this is already better than old Cabana! Most of the notes I have so far are UI issues.
|
Beta Was this translation helpful? Give feedback.
-
Feature Part 1: Add a textbox that I can type in a timestamp to go to. There should also be a button beside the textbox that says "Goto" or I can press return/enter key. Feature Part 2: When I make a signal I want to be able see the timestamp where that signal changes. In it's simplest form I can imagine 2 buttons on each signal graph. One button could read "Prev Change" and "Next Change". When I press the buttons It would fill the textbox with the timestamp then I can press "Goto" btn when I am ready. I think it would be a good idea to think about how advance this feature could become. Another level of complexity would be to goto next/prev timestamp where signal is ==, >, < a value. The options could be selected with a dropdown list or a new window. Another idea that may also be easier to implement would be to automatically list all the recorded states of a signal as a histogram. |
Beta Was this translation helpful? Give feedback.
-
Some appreciation for the great tools @deanlee has been writing from our internal slack: |
Beta Was this translation helpful? Give feedback.
-
Alright, here's round two of feedback @deanlee. It's got a lot of nice things that web cabana doesn't have, but there's still some things I'm missing from web cabana. feature requests
bugs
|
Beta Was this translation helpful? Give feedback.
-
Nice work so far! Just some things I noticed:
|
Beta Was this translation helpful? Give feedback.
-
current cabana in |
Beta Was this translation helpful? Give feedback.
-
@jyoung8607 I'm writing a quick fix for this little endian flipping issue #26409 . there are still some other issues with the BinaryView, I'll continue to improve it after this quick fix. |
Beta Was this translation helpful? Give feedback.
-
Great work @deanlee! Small complaint, maybe somebody already mentioned this. Changing signal names can sometimes be a bit frustrating because they change order, and the cursor doesn't stay with the current signal. Either the cursor needs to stick with the current signal, or order signals by start bit so the ordering is constant. The biggest feature from web cabana I'm missing is overlapping multiple lines on the same plot. This is useful when comparing request vs actual value, or seeing if two signals represent the same physical value. |
Beta Was this translation helpful? Give feedback.
-
some things I wish cabana had:
|
Beta Was this translation helpful? Give feedback.
-
@deanlee let me know if you want to write something about new cabana for the 0.9 blog post. no problem if not, I can write something up |
Beta Was this translation helpful? Give feedback.
-
Thank you @deanlee for the new cabana. It's a huge improvement! |
Beta Was this translation helpful? Give feedback.
-
So responsive! Also found a few bugs:
|
Beta Was this translation helpful? Give feedback.
-
I am having an issue using wsl2 with the new cabana. When executing w.show(); it exits and I get a segmentation fault. stack trace:
if I remove w.show();, the program runs. plotjuggler works but so my display is configured. I have the newest Nvidia drivers on windows 11. |
Beta Was this translation helpful? Give feedback.
-
Can we print why it failed to load a DBC from clipboard? It shows the reason when you try to load the file. |
Beta Was this translation helpful? Give feedback.
-
I tried to use the "Find Signal" option while live streaming to find a button in the car, but it didn't seem to work, or wasn't very intuitive. I typed what value I expected, held the button, then pressed enter a bunch of times. I then let go and set the value to 0, then pressed enter again. I repeated this several times but the possible signals never went down, and it never found the button. Is this how it's supposed to work? |
Beta Was this translation helpful? Give feedback.
-
Hmm, high values cause weird graph behavior |
Beta Was this translation helpful? Give feedback.
-
It would be cool to have a switch (in the GUI or somewhere) for Panda to turn on receiving mode (NO_OUTPUT instead of SILENT). |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
Is it normal for certain instances of Cabana to use a few GB while others are a few hundred MB? |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
@deanlee Feature request. Would be nice to have a toggle to switch between looking at can and sendcan. This is useful when running controlsd after modifying a car port can function. |
Beta Was this translation helpful? Give feedback.
-
Feature request. I would like the ability to be able to copy my selection from the history log view like this: Ideally if i copy values, it would add a comma seperator behind each value in the same row and a \r if its a new column. I am able to use PowerToys OCR text selector to do it though but it only works for rows or columns but it doesn't format it properly if i do rows and columns at the same time |
Beta Was this translation helpful? Give feedback.
-
Feature Request: In the loghistory widget it would be nice to be able to add complex logical filters. There could be a button labled "Complex filter" which would enable the ability to add more filters and then you can use a logic expression to specify which boolean expressions for the filters. Each filter would be given an index. The user would then type in a logical expression in a text box like "(Filter1 and Filter2 and Filter3) or (Filter4 and Filter5 and Filter6)" or another way would be to use symbols and the filter index number like this "( 1 | 2 | 3 ) & ( 4 | 5 | 6 )". This would require that the filter persists through the session and can be loaded again after restart. Might be a little complicated and may not be that useful but it's an idea. |
Beta Was this translation helpful? Give feedback.
-
I've been getting segfaults lately on M1 macos whenever cabana enters segment 16 or later of a route. Segments 0-15 have no issues. It happens either when I let the stream play through the end of segment 15, or if I launch the segment directly by appending Log from one such incident: segfault.log |
Beta Was this translation helpful? Give feedback.
-
Looks like the surpress highlight breaks after seeking. All signals are highlighted again. |
Beta Was this translation helpful? Give feedback.
-
@deanlee it would be nice if Shift+Scrolling in the message view made it scroll sideways, like web browsers operate! |
Beta Was this translation helpful? Give feedback.
-
@deanlee zooming seems to hang cabana, and the timeline seeker doesn't update until the segment fully downloads (it used to update immediately) cabana.zooming.slow3.mp4 |
Beta Was this translation helpful? Give feedback.
-
It's still very often that Cabana hangs on exit and I have to manually force close it with |
Beta Was this translation helpful? Give feedback.
-
@deanlee has been working on a rewrite of comma cabana in Qt. Starting this thread for feedback now that it's in a stable state.
original cabana: https://cabana.comma.ai
new cabana: https://github.com/commaai/openpilot/tree/master/tools/cabana
Beta Was this translation helpful? Give feedback.
All reactions