Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TranscriptionTeeClient __call__ ---> class methods #199

Open
AIWintermuteAI opened this issue Apr 4, 2024 · 1 comment
Open

TranscriptionTeeClient __call__ ---> class methods #199

AIWintermuteAI opened this issue Apr 4, 2024 · 1 comment

Comments

@AIWintermuteAI
Copy link

Hi, @makaveli10 !
Great job on creating this!

I like how well written and organized the code is. One thing that does seem a little bit off, as a design decision is overloading the call of the TranscriptionTeeClient. Would it make more sense to rather have explicit methods for different tasks, i.e. process_file, process_hls and process_mic ? Then each of this methods can have its own relevant args.

If this makes sense, I can make a quick PR.

@makaveli10
Copy link
Collaborator

@AIWintermuteAI absolutely, feel free to open a PR and keep them coming. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants