You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I like how well written and organized the code is. One thing that does seem a little bit off, as a design decision is overloading the call of the TranscriptionTeeClient. Would it make more sense to rather have explicit methods for different tasks, i.e. process_file, process_hls and process_mic ? Then each of this methods can have its own relevant args.
If this makes sense, I can make a quick PR.
The text was updated successfully, but these errors were encountered:
Hi, @makaveli10 !
Great job on creating this!
I like how well written and organized the code is. One thing that does seem a little bit off, as a design decision is overloading the call of the TranscriptionTeeClient. Would it make more sense to rather have explicit methods for different tasks, i.e. process_file, process_hls and process_mic ? Then each of this methods can have its own relevant args.
If this makes sense, I can make a quick PR.
The text was updated successfully, but these errors were encountered: