Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Sobelow (Elixir) #627

Open
houllette opened this issue Jun 2, 2022 · 3 comments
Open

Add Support for Sobelow (Elixir) #627

houllette opened this issue Jun 2, 2022 · 3 comments

Comments

@houllette
Copy link

We've been using Salus for awhile now at my current company and have integrated Sobelow into it for the purposes of scanning Elixir code.

Our implementation is not ready for primetime via a PR and we're unsure if we have time to dedicate to cleaning up our fork so it's ready for a PR; so we'd love some assistance getting it integrated from official maintainers so we don't have to continue supporting our fork as it drifts further and further away from the main branch.

@maitrayshah-cb
Copy link
Contributor

Hi @houllette, apologies for the delayed reply, someone (me) dropped the ball there. It is definitely a great idea to get it merged in the main branch and also expanding support to a new language. Unfortunately, I am not sure how much time we can commit at this point right now but let me check with the team.
That said we've had request to publish more documentation around "How to write a scanner" which is being worked on so I can try and get those out to you if that helps.

@houllette
Copy link
Author

No worries, @maitrayshah! More documentation would be significantly helpful! There are some ideas floating around internally to dedicate some resources to making the merge a reality, so those docs good come in handy real soon! Thanks!

@maitrayshah-cb
Copy link
Contributor

@houllette We added a doc detailing some information on how to add a scanner. Feel free to take a look at that and suggest any improvements we can make to it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants
@houllette @maitrayshah-cb and others