Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate against Clair for Docker image scanning #61

Open
nishils opened this issue Jun 4, 2019 · 2 comments
Open

Integrate against Clair for Docker image scanning #61

nishils opened this issue Jun 4, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@nishils
Copy link
Contributor

nishils commented Jun 4, 2019

This will take some work as Clair would need to be external to Salus. We would add support for pushing images to Clair and getting the results.

We can provide a way to configure against an existing Clair instance but would not want to make Clair a part of Salus.

I have used paclair before and seemed to work rather well for this sort of use case.

@nishils nishils added the enhancement New feature or request label Jun 4, 2019
@jborrey
Copy link
Contributor

jborrey commented Jun 6, 2019

This will be the first time that Salus has to deal with concurrency outside of its control. Would you have Salus wait until a Clair result is read (presumably the container was pushed to Clair ahead of time)?

Something that was never built, but was part of the original vision of Salus was to have a a SalusServer which would collect and display results for you - pretty similar to the dashboards run by Snyk, Hakiri and friends. Right now we get away without it if you dump all of the Salus reports into a logging pipeline which you can view.

The server would be useful for this sort of thing though but it's a lot of work. What if Clair just also dumped logs into the same pipeline with the same set of keys so that you can easily group them together?

@mattlorimor
Copy link

mattlorimor commented Nov 13, 2020

In order to meet the spirit of doing this, would integrating something like Aqua's Trivy scanner be more desirable? It's fairly easy to integrate it into SDLC/CI systems, so I imagine it would lend itself well to the way Salus runs things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants
@mattlorimor @jborrey @nishils and others