Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_diff method to changesets #88

Open
lukaszb opened this issue Oct 15, 2011 · 1 comment
Open

Add get_diff method to changesets #88

lukaszb opened this issue Oct 15, 2011 · 1 comment

Comments

@lukaszb
Copy link
Member

lukaszb commented Oct 15, 2011

Synopsis:

def get_diff(self, other)

It should return diff as a unicode. other parameter should be optional. Diff format should be git (requires -g switch to be turned for hg command).

I believe it should be assumed as low level method and simply return strings. We can then create another method that would parse diff and return more structured object. @marcinkuzminski - feedback please :)

Eventually, that method should also allow paths parameter to be passed.

@marcinkuzminski
Copy link
Member

nice, just do we implement this as a changeset method or a filenode method ? And again if for example it's a changeset method should it return iterator that returns on string stream or maybe we split this somehow ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants