Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Repository.revision attribute - we should use id specific for each backends #43

Open
lukaszb opened this issue Jan 23, 2011 · 0 comments

Comments

@lukaszb
Copy link
Member

lukaszb commented Jan 23, 2011

Currently Repository.get_changeset accepts revision number (given as integer) which is generally wrong for both hg and git.

Mercurial can operate rather easily with that however for instance one may push repository to the server on which vcs process repositories management, then tries to use i.e. 10 as changeset id and gets different results from local repository. With integers there are integrity problems and only full hexes identifies changesets properly.

Git doesn't support integers as id numbers for commits in any way (there are some possibility to write own script but it would works properly only for new repositories which is not the case mainly).

That said, we should deprecate integer identification. This is great feature but it just is not proper one for repository management/browsing.

Applications should implement such feature on its own.


Reference: https://bitbucket.org/marcinkuzminski/vcs/issues/43/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant