Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Pages from Components #81

Open
paul-rinaldi opened this issue Jul 27, 2020 · 5 comments
Open

Separate Pages from Components #81

paul-rinaldi opened this issue Jul 27, 2020 · 5 comments

Comments

@paul-rinaldi
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, there are pages and components in the same folder called components, it's not easy to navigate by a pogrammer.

Describe the solution you'd like
/src/components/ (components folder)
/src/pages/ (pages folders)

@paul-rinaldi paul-rinaldi added enhancement New feature or request good first issue Good for newcomers labels Jul 27, 2020
@paul-rinaldi paul-rinaldi added this to the Sprint 4 (Briareus) milestone Jul 27, 2020
@hdenisenko
Copy link
Contributor

Quick question about this - does this mean for something like /src/components/CalendarPage you want it split into /src/page/CalendarPage/index.js and the modal components in the components folder?

@Caryyon
Copy link

Caryyon commented Aug 11, 2020

it sounds like you want
/pages to be a place for actual routing && /components to be components that can be used within those pages.
this can help with confusion of where is the page implemented and where is what it's built out of.
is this going to mess things up for everyone else's branch at this point?

@hdenisenko
Copy link
Contributor

that's a good question - there'll probably be a fair amount of merge conflicts. @Caryyon @paul-rinaldi is this a change we want to introduce while others are working on other branches?

@Caryyon
Copy link

Caryyon commented Aug 23, 2020

it's very similar to how Next.js handles the matter.
pages = pages
components = small chunks of functionality.

@paul-rinaldi
Copy link
Collaborator Author

Yes @Caryyon has it right, this should be done later, I'm making more relevant issues soon (tech debt like this isn't too bad at all)

@paul-rinaldi paul-rinaldi added technical debt/refactor and removed good first issue Good for newcomers enhancement New feature or request labels Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Decarceration Platform
  
Awaiting triage
Development

No branches or pull requests

3 participants