Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of Life (Dev):: maintainers cannot view their frontend changes due to dependencies on firebase credentials #106

Open
paul-rinaldi opened this issue Nov 27, 2020 · 2 comments
Labels
question Further information is requested
Milestone

Comments

@paul-rinaldi
Copy link
Collaborator

Describe the bug
To develop well, developers need to see the impact they are having.

To Reproduce
Steps to reproduce the behavior:

  1. cd web-app
  2. run: npm start
  3. Navigate to Services Page
  4. Observe the map not loading, though the services does load with initial mock service provider data

Expected behavior
The developer environment should match as closely to prod as possible.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Quickest solution (best) might be to ensure that we always have mocked up-to-date data checked into the repository as initialState of components before fetches are made using credentials.

Also, am I missing anything in this issue? Comment below. Thanks!!!!

@paul-rinaldi paul-rinaldi added the question Further information is requested label Nov 27, 2020
@paul-rinaldi paul-rinaldi added this to the Sprint 3 (Atlas) milestone Nov 27, 2020
@paul-rinaldi paul-rinaldi changed the title QOL: maintainers cannot view their frontend changes due to dependencies on firebase credentials Quality of Life (Dev):: maintainers cannot view their frontend changes due to dependencies on firebase credentials Nov 27, 2020
@brian221
Copy link

brian221 commented Dec 8, 2020

I believe the way around this is to use the firebase command line tools.

  1. Add any developers with at least a developer role to a non-production instance of the firebase project.
  2. Use the firebase CLI to run using local http functions

https://firebase.google.com/docs/cli#emulate_your_project_using_local_http_functions

@brian221
Copy link

brian221 commented Dec 8, 2020

I may be overthinking the issue...you likely have Firebase credentials directly in your UI code.
Make those environment variables using .env. Then maintainers can be given a non-prod set of credentials they can use for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Decarceration Platform
  
Awaiting triage
Development

No branches or pull requests

2 participants