dev: in lint, ignore cached test results
#124163
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since lint checks look at the whole tree, but do not depend on the whole tree at the Bazel level, it can cache test results incorrectly when the tree content has actually changed. We ask `bazel` to never cache test results. Closes cockroachdb#124152 Epic: CRDB-17171 Release note: None
|
This change is |
rail
approved these changes
May 14, 2024
|
bors r=rail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since lint checks look at the whole tree, but do not depend on the whole tree at the Bazel level, it can cache test results incorrectly when the tree content has actually changed. We ask
bazelto never cache test results.Closes #124152
Epic: CRDB-17171
Release note: None