Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: dev lint can cache too aggressively #124152

Closed
rickystewart opened this issue May 14, 2024 · 0 comments · Fixed by #124163
Closed

dev: dev lint can cache too aggressively #124152

rickystewart opened this issue May 14, 2024 · 0 comments · Fixed by #124163
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf

Comments

@rickystewart
Copy link
Collaborator

rickystewart commented May 14, 2024 •
edited by cockroach-jira-scripts

Running dev lint multiple times with the same test filter can result in bazel using the cached test even if the underlying code has changed.

Epic: CRDB-17171

Jira issue: CRDB-38731
@rickystewart rickystewart added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system T-dev-inf labels May 14, 2024
@rickystewart rickystewart mentioned this issue May 14, 2024
Merged
craig bot pushed a commit that referenced this issue May 14, 2024
@rickystewart
Merge #124163
7cafe60 
124163: dev: in `lint`, ignore cached test results r=rail a=rickystewart

Since lint checks look at the whole tree, but do not depend on the whole tree at the Bazel level, it can cache test results incorrectly when the tree content has actually changed. We ask `bazel` to never cache test results.

Closes #124152

Epic: CRDB-17171
Release note: None

Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
@craig craig bot closed this as completed in b4ebe8f May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-dev-inf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dev: in lint, ignore cached test results rickystewart/cockroach
1 participant
@rickystewart