Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamingccl: deflake a few tests #124162

Merged

Conversation

msbutler
Copy link
Collaborator

As of #123934, the producer job succeeds instead of fails. This patch teaches some test infra about this.

Fixes #124139
Fixes #124138
Fixes #124151
Fixes #124137

Release note: none

@msbutler msbutler requested a review from dt May 14, 2024 19:05
@msbutler msbutler self-assigned this May 14, 2024
@msbutler msbutler requested a review from a team as a code owner May 14, 2024 19:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

As of cockroachdb#123934, the producer job succeeds instead of fails. This patch teaches
some test infra about this.

Fixes cockroachdb#124139
Fixes cockroachdb#124138
Fixes cockroachdb#124151
Fixes cockroachdb#124137

Release note: none
@msbutler msbutler force-pushed the butler-streamingccl-success-flake branch from af03a26 to 1269197 Compare May 14, 2024 19:07
@msbutler msbutler requested a review from kev-cao May 14, 2024 19:27
Copy link
Contributor

@kev-cao kev-cao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msbutler
Copy link
Collaborator Author

TFTR!

bors r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants