allocatorimpl: log when allocate target excluded due to full disk #118313
Assignees
Labels
A-kv-distribution
Relating to rebalancing and leasing.
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
O-support
Originated from a customer
P-2
Issues/test failures with a fix SLA of 3 months
T-kv
KV Team
Projects
Comments
kvoli
added
C-enhancement
kvoli
added
O-support
craig bot
pushed a commit
that referenced
this issue
May 14, 2024
124073: allocatorimpl: include full store count in allocator error r=andrewbaptist a=kvoli An allocator error is returned when a new or replacement replica cannot be allocated to a store. The error details how many live stores there are and how many hold existing replicas along with constraints. The error makes determining the cause of up-replication stalls easier. Also include the number of alive stores which are ineligible due to full disks in the error. The updated error message when at least one store is full: ``` 0 of N live stores are able to take a new replica for the range (X full disk, ...) ``` Where N is the number of live stores, of which X have a full disk. Resolves: #118313 Release note: None Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
blathers-crl bot
pushed a commit
that referenced
this issue
May 14, 2024
An allocator error is returned when a new or replacement replica cannot be allocated to a store. The error details how many live stores there are and how many hold existing replicas along with constraints. The error makes determining the cause of up-replication stalls easier. Also include the number of alive stores which are ineligible due to full disks in the error. The updated error message when at least one store is full: ``` 0 of N live stores are able to take a new replica for the range (X full disk, ...) ``` Where N is the number of live stores, of which X have a full disk. Resolves: #118313 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
We log an allocator error when unable to allocate a target due to throttled stores, no stores matching constraints or not enough stores in the cluster:
It would be helpful to also include information on stores which are currently full, checked here:
cockroach/pkg/kv/kvserver/allocator/allocatorimpl/allocator_scorer.go
Line 1116 in dc7c41a
Jira issue: CRDB-35675
The text was updated successfully, but these errors were encountered: