Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage page device table started producing accesibility warning #20457

Closed
KKoukiou opened this issue May 10, 2024 · 3 comments · Fixed by #20458
Closed

Storage page device table started producing accesibility warning #20457

KKoukiou opened this issue May 10, 2024 · 3 comments · Fixed by #20458

Comments

@KKoukiou
Copy link
Contributor

Page:

warning: Th: Table headers must have an accessible name. If the Th is intended to be visually empty, pass in screenReaderText. If the Th contains only non-text, interactive content such as a checkbox or expand toggle, pass in an aria-label.

@martinpitt
Copy link
Member

Funny you should ask now 😁 @mvollmer is just fixing that in #20358.

@mvollmer
Copy link
Member

Funny you should ask now 😁 @mvollmer is just fixing that in #20358.

Actually, the Storage page uses Table directly, so #20358 is not going to fix this. But as soon as we have decided what to do in #20358, I'll do the same wherever we get this warning, such as in pkg/storaged and c-machines.

@mvollmer
Copy link
Member

good-first-issue, haha... :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants