Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebasing should have a confirmation #428

Open
garrett opened this issue Oct 5, 2023 · 0 comments
Open

Rebasing should have a confirmation #428

garrett opened this issue Oct 5, 2023 · 0 comments

Comments

@garrett
Copy link
Member

garrett commented Oct 5, 2023

Rebasing doesn't have a confirmation.

It just rebases (without proper progress, and is uncancelable) and then instantly reboots when done.

  • There should be a confirmation, especially as a reboot is done after rebasing.
  • It should have progress. (Or at least a spinner.)
  • Ideally it would be able to be cancelled. (I can hit control-c in the middle of a rebase on the command line, so I think it can be cancelled? But it might not be able to be cancelled via API.)

What information can we show in the confirmation modal? Download size? Definitely something about rebooting. Probably what version which will be pulled? And perhaps the date? (Although the version is usually the date, basically.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant