Fix disk "Used" value #1467
Draft
Fix disk "Used" value #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showing "allocation" in the UI doesn't make much sense. According to the manpage [1] it describes "offset of highest written sector in bytes". Showing the "physical size of source file in bytes" is much more useful. Thanks to @shodanshok for figuring this out! Fixes cockpit-project#1423 [1] https://www.libvirt.org/manpages/virsh.html
|
Yeah, nothing -- so we definitively need a proper test case for "Used" for both running and stopped machines first. That value isn't very predictable, but at least a plausible range should be tested that guards us against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing "allocation" in the UI doesn't make much sense. According to the manpage [1] it describes "offset of highest written sector in bytes". Showing the "physical size of source file in bytes" is much more useful.
Thanks to @shodanshok for figuring this out!
Fixes #1423
[1] https://www.libvirt.org/manpages/virsh.html
This was one of these "looks like a quick fix" issues, but it's not -- this is definitively not working yet, but I want to see if we get a more meaningful test failure than just the unexpected "error: input is not a number" -- i.e. where we cover this.