Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember State filter settings in Machines interface #1032

Open
mister0825 opened this issue Apr 16, 2023 · 3 comments · May be fixed by #1035
Open

Remember State filter settings in Machines interface #1032

mister0825 opened this issue Apr 16, 2023 · 3 comments · May be fixed by #1035
Labels
enhancement New feature or request

Comments

@mister0825
Copy link

In the Virtual Machines interface, after a user filters the view to show only running VMs, the view reverts back to 'All' when navigating away and then back to the interface.

Steps to reproduce:

  1. Filter VM view by 'State: Running'
  2. Switch to the Storage Pools or Networks tab.
  3. Switch back to the main VM view, filter reverts back to 'State: All'

The ask is for the filter settings (regardless of which state is being selected) to be remembered during the active session.
@mister0825 mister0825 added the enhancement New feature or request label Apr 16, 2023
@KKoukiou KKoukiou transferred this issue from cockpit-project/cockpit Apr 17, 2023
@garrett
Copy link
Member

garrett commented Apr 17, 2023

I agree with this suggestion. 👍 Thanks for filing the issue!

We should always remember filtering state like this within Cockpit sessions. (I know we do this in several other places outside of Cockpit-Machines already.) In general, filtering like this should be remembered in the session, but not across sessions.

subhoghoshX added a commit to subhoghoshX/cockpit-machines that referenced this issue Apr 18, 2023
@subhoghoshX
Remember VM state filter settings
7cc526e 
Fixes cockpit-project#1032
@subhoghoshX subhoghoshX linked a pull request Apr 18, 2023 that will close this issue
Open
@shaul75
Copy link

shaul75 commented Apr 18, 2023 •
edited

Another one which bugs me is the Console view.
"Desktop viewer" is always selected by default (when present), I constantly switch it to serial console, only to be reminded of how tiny the console box is, so I click the "Expand" button which does make it more useable, but at the same time it decides to revert the selection back to "Desktop viewer" 😭

subhoghoshX added a commit to subhoghoshX/cockpit-machines that referenced this issue Apr 19, 2023
@subhoghoshX
Remember VM state filter settings
f413594 
Fixes cockpit-project#1032
@garrett garrett mentioned this issue Apr 19, 2023
Open
@garrett
Copy link
Member

garrett commented Apr 19, 2023

@shaul75: Thanks for additional feedback! I've opened another issue based on your comment.

We're also in the process of redesigning and reimplementing the console and we'll try to make sure this is addressed soon too. The new designs should help improve the the desktop viewer experience as well.

subhoghoshX added a commit to subhoghoshX/cockpit-machines that referenced this issue Apr 20, 2023
@subhoghoshX
Remember VM state filter settings
30eb8fb 
Fixes cockpit-project#1032
subhoghoshX added a commit to subhoghoshX/cockpit-machines that referenced this issue Apr 20, 2023
@subhoghoshX
Remember VM state filter settings
274ffaa 
Fixes cockpit-project#1032
subhoghoshX added a commit to subhoghoshX/cockpit-machines that referenced this issue May 8, 2023
@subhoghoshX
Remember VM state filter settings
4ffd854 
Fixes cockpit-project#1032
subhoghoshX added a commit to subhoghoshX/cockpit-machines that referenced this issue May 8, 2023
@subhoghoshX
Remember VM state filter settings
4a572ec 
Fixes cockpit-project#1032
subhoghoshX added a commit to subhoghoshX/cockpit-machines that referenced this issue May 8, 2023
@subhoghoshX
Remember VM state filter settings
9992f8c 
Fixes cockpit-project#1032
subhoghoshX added a commit to subhoghoshX/cockpit-machines that referenced this issue May 8, 2023
@subhoghoshX
Remember VM state filter settings
8bc268c 
Fixes cockpit-project#1032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remember VM state filter settings subhoghoshX/cockpit-machines
3 participants
@garrett @mister0825 @shaul75