Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every fsinfo update re-draws the SidebarPanel #227

Open
jelly opened this issue Jan 30, 2024 · 1 comment
Open

Every fsinfo update re-draws the SidebarPanel #227

jelly opened this issue Jan 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jelly
Copy link
Member

jelly commented Jan 30, 2024

There are two issues here:

  • We re-render the SidebarPanel every time we get an inotify change event on the current directory, this is unneeded
  • Every re-render runs cockpit.spawn and issues file --brief but when nothing is selected it runs /home/admin/undefined. Note that no console.warn is issued.

This is not a huge performance issue, but imo worth to fix.

@jelly jelly added the bug Something isn't working label Jan 30, 2024
@jelly
Copy link
Member Author

jelly commented Jan 30, 2024

The SidebarPanel get's all files passed to, so that explains the re-render on updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant