-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icons #226
Comments
Here's what the new icons look like (out of context): They're from ForkAwesome filetype icons: https://forkaweso.me/Fork-Awesome/icons/#file-type Here's the file with optimized SVGs: ⬇ filetypes.zip Screenshot crop from Nautilus: (I've included audio and video too... why not? We can skip those though... the others are more important, really.) The license for the icons is OFL 1.1 (which is compatible): https://forkaweso.me/Fork-Awesome/license/ We're already using a fork of Font Awesome in PatternFly, also under the OFL. We probably want to include them with an Summary of that page on usage:
Object wins out. It looks like this: <object type="image/svg+xml" data="image.svg"></object> I'll include the ones we should use, but I'll make sure they're optimized. Although, since these are basically outlines, I think we could also do clip-path with the SVGs too, which would let us handle it in pure CSS, and that would probably scale pretty well too. We could even make a single file with all of them, have an ID and use the clip-path specified by that ID. Or just use individual files. Or copy the path object out of the SVG and use it within the CSS with |
The link badge is PatternFly's |
For file types that the web browser can display (such as images), will the user be able to double click on the file to display it in the web browser? |
Here's how the new icons would look:
Things that are changed:
The icons should exist in one place and be referenced instead of being inline SVG. (Using inline SVG is not great for performance at the level of a thousand items, which some system directories have.)
The text was updated successfully, but these errors were encountered: