Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please expose lower-level middleware chain #49

Open
mgerlach-klick opened this issue Jan 2, 2019 · 3 comments
Open

Please expose lower-level middleware chain #49

mgerlach-klick opened this issue Jan 2, 2019 · 3 comments

Comments

@mgerlach-klick
Copy link
Contributor

I'm trying to stuff https://github.com/bertrandk/ring-gzip into the middleware chain, and it's not easy, since it needs to be below the level that you expose with the wrap-routes function :)

@swlkr
Copy link
Member

swlkr commented Jan 7, 2019

Hmm, I could put the middleware chain in the template instead of the lib, or maybe make it an option on project creation?

@mgerlach-klick
Copy link
Contributor Author

I'd put it in the template. Honestly, I wish all of coast was a template and none of it lib. There is always a tiny thing that i want to change that the lib doesn't expose and I always go to ridiculous lengths to not have to clone the project :)
I remember starting with Luminus and hating that all the files were everywhere, but I've really gotten around to that approach. The flexibility always ends up being more valuable than a cleaner working directory.

@swlkr
Copy link
Member

swlkr commented Mar 16, 2019

I did a lot of work on cleaning up the middleware chain, but I still couldn’t really separate out the middleware from the main app because of the way I do routes as keywords instead of actual vars or qualified symbols, but I am still interested in adding a flag to the generator to support this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants