Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reading gctx from a non-fs file object #64

Open
idavydov opened this issue Apr 8, 2020 · 1 comment
Open

reading gctx from a non-fs file object #64

idavydov opened this issue Apr 8, 2020 · 1 comment

Comments

@idavydov
Copy link

idavydov commented Apr 8, 2020

Hi,
In our settings there is often a need to read a .gctx file from a non-file (i.e. python file object).
Currently it is not possible with cmapPy. The parse method explicitly checks for the filename:

if not os.path.exists(full_path):

On the other hand h5py supports any file objects.

Would it be possible to rely on duck-typing in the parse function instead to allow for different types of input file objects?

@idavydov
Copy link
Author

idavydov commented Apr 9, 2020

Apparently, there are problems reading HDF5 from S3 at the moment. See here: h5py/h5py#1530

So currently depends on the upstream functionality of h5py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant