We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/cloudposse/terraform-aws-components/blob/main/modules/ecs-service/main.tf#L259
deployment_controller_type = lookup(local.task, "deployment_controller_type", null) ends up passing in null which does not default to ECS for this conditional https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/blob/main/main.tf#L642 so circuit_breaker_deployment_enabled and circuit_breaker_rollback_enabled never get enabled.
deployment_controller_type = lookup(local.task, "deployment_controller_type", null)
null
ECS
circuit_breaker_deployment_enabled
circuit_breaker_rollback_enabled
... task: circuit_breaker_deployment_enabled: true circuit_breaker_rollback_enabled: true
...should trigger...
~ deployment_circuit_breaker { ~ enable = false -> true ~ rollback = false -> true }
Changing the values should trigger an update, but it requires manually setting deployment_controller_type: ECS.
deployment_controller_type: ECS
Enable the circuit breaker for a task without explicitly setting the deployment controller.
No response
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the Bug
https://github.com/cloudposse/terraform-aws-components/blob/main/modules/ecs-service/main.tf#L259
deployment_controller_type = lookup(local.task, "deployment_controller_type", null)
ends up passing innull
which does not default toECS
for this conditional https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/blob/main/main.tf#L642 socircuit_breaker_deployment_enabled
andcircuit_breaker_rollback_enabled
never get enabled.Expected Behavior
...should trigger...
Changing the values should trigger an update, but it requires manually setting
deployment_controller_type: ECS
.Steps to Reproduce
Enable the circuit breaker for a task without explicitly setting the deployment controller.
Screenshots
No response
Environment
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: