Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly initialize GaugeSolution if gauge has only one reading. #615

Closed
wants to merge 1 commit into from
Closed

Properly initialize GaugeSolution if gauge has only one reading. #615

wants to merge 1 commit into from

Conversation

ketch
Copy link
Member

@ketch ketch commented Feb 24, 2019

This is a simple fix to resolve clawpack/visclaw#172 by making the resulting array 2-dimensional even if the gauge file only has one line.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 4b25724 on ketch:one_value_gauge_fix into efc2c27 on clawpack:master.

@rjleveque rjleveque mentioned this pull request Feb 24, 2019
Merged
@rjleveque
Copy link
Member

I think you mean data not x in your fix.

@ketch
Copy link
Member Author

ketch commented Apr 16, 2019

This is replaced by #616.

@ketch ketch closed this Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reading gauges bombs if there's only 1 line in the fort.gauge file
3 participants
@ketch @coveralls @rjleveque