Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run-time array sizing for "work" arrays #76

Open
ketch opened this issue Jul 25, 2014 · 0 comments
Open

Use run-time array sizing for "work" arrays #76

ketch opened this issue Jul 25, 2014 · 0 comments

Comments

@ketch
Copy link
Member

ketch commented Jul 25, 2014

In, for instance, the 3D Euler solvers, there are some work arrays whose size is hard-coded. It would be cleaner to size them at run-time, but currently this incurs a performance penalty; see discussion in #75. It seems that in some tests the dynamic allocation leads to a 6-7% slowdown. Once we switch to modules for Riemann solvers, we can size these at run time but still only allocate them once, as module data.

mandli added a commit to mandli/riemann that referenced this issue Mar 19, 2015
allow environment passed in to make_all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant