Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riemann solvers containing common blocks not thread safe #29

Open
rjleveque opened this issue Jul 19, 2013 · 2 comments
Open

Riemann solvers containing common blocks not thread safe #29

rjleveque opened this issue Jul 19, 2013 · 2 comments
Labels

Comments

@rjleveque
Copy link
Member

Most of the Euler Riemann solvers still have common blocks, which are not thread safe with OpenMP.

This showed up when testing amrclaw/tests/quadrants.

Some other Riemann solvers also have common blocks. Need to clean all of these up.

@ketch
Copy link
Member

ketch commented Jul 25, 2013

Almost all of the non-threadsafe common blocks were removed in #30. The only remaining one is the use of dxcom, dycom in the mapped grid solvers (which is non-threadsafe in AMRClaw only).

@ketch ketch added the parallel label Jul 12, 2014
@ketch
Copy link
Member

ketch commented Nov 2, 2014

The only problem left (before we can close this issue) is the use of dxcom and dycom in the solvers for shallow water on the sphere. I'm not even sure they're being used correctly there, though.

mandli added a commit to mandli/riemann that referenced this issue Mar 19, 2015
maojrs pushed a commit to maojrs/riemann that referenced this issue Mar 19, 2015
Update multilayer SWE application for 5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants