-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional digits to gauge IDs #541
Comments
It would be good to add a warning in general. I doubt anyone will have more than 1e7 gauges, but it's quite possible someone will try to use a gauge number with more than 8 digits in order to match a numbering system used by some other agency. (NOAA generally uses 7 digit gauge numbers). |
Good point on the simple overflow. This could probably be implemented in Python quite easily now that I think about it. |
I was thinking about this again and wanted to ping those interested as to how we change the name. Options I came up with:
The last of these could also do the only non-zero left digits too. |
Having leading zeros is useful if you have e.g. gauge numbers 1 to 100 and you want One other possibility would be to have e.g. 7 digits with leading zeros by default, but with the option that more than 7 digits can also be handled, e.g. in Python:
Or even make the default 5 digits with leading zeros to agree with the current naming scheme but allow more digits. (I think I prefer this for backward compatibility and because 7 digits seems more unwieldy in general, and often not needed.) I don't really think we need an underscore, but don't feel strongly about that. |
I like the suggestion to always have at least 5 digits but allow more if requested. The |
Resolved in $615. |
As discussed on$10^5$ gauges GeoClaw will not warn the user and will simply loop around, corrupting the output files. It was also pointed out that it would be convenient to be able to directly use the gauge IDs that are often greater than 5 digits and for coastal stations are 7 digits long.
claw-users
if you have too many gauges such that you have more thanI would propose:
The text was updated successfully, but these errors were encountered: