-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Synthetic Storm Surge Example "Interesting" #498
Comments
@mandli, I was remaking the galleries for v5.8.0 and discovered that this example now dies with "too many dt reductions" at |
Odd, I thought it was working before with order 2 when I was running it before but I agree, it seems to not be working although I don't see why right now. I will work on this a bit but if I don't see the issue right away we should roll back the order to 1 I suppose. |
Strangely when trying to debug this I increased the number of output and everything ran fine. More puzzling, when I reduced the number of output it also ran fine. |
Yes, increasing the number of output times seems to make it run, not sure why. Also it takes hours to run, unlike most most things in the examples directories, and doesn't seem to illustrate anything in particular so I'm not sure what the goal is with this example. For now I'm in favor of a quick fix so we can release 5.8.0, if possible. |
Hours to run? For me it takes a couple of minutes, which admittedly is still longer than the other examples. More importantly though is the stability of the problem either with more or less output steps. As to what it was supposed to demonstrate, I was not aware that the example had the gauges removed. It was supposed to show how to setup an example synthetic test case, which is something I constantly get asked about. Right now this is pretty basic, which is why this issue was opened. In principle this could be more a demo with a Jupyter notebook added with some more explanation. |
Am I looking at the right example? In |
That's the right one. This is the timing I have with 3 outputs:
|
Something strange is happening in this example, see clawpack#498. It also needs some gauges and other enhancements to better illustrate use of the storm surge code, and then perhaps put in the apps repository?
We decided to remove this example for now since it's giving strange behavior. When I run it with order=2 and more output times, something funny happens at time = 0 days that causes it to refine the entire domain to the finest level, leading to the slow run time. Perhaps something about the synthetic storm being used? It also needs some gauges and other enhancements to better illustrate use of the storm surge code, and then perhaps put in the apps repository? Let's leave this issue open as a reminder to follow up on it. |
Currently the synthetic storm surge example works but does not have a lot going on. It would be nice to make this example a bit more interesting by doing things such as
These are just suggestions of course.
As this example has been removed this issue now either needs to add this example back or should move what was here back into the apps repository.
The text was updated successfully, but these errors were encountered: