Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please get rid of six dependency in setup.py #244

Open
dalcinl opened this issue Mar 6, 2024 · 1 comment
Open

Please get rid of six dependency in setup.py #244

dalcinl opened this issue Mar 6, 2024 · 1 comment

Comments

@dalcinl
Copy link

dalcinl commented Mar 6, 2024

@ketch Could you please make a PR with the following patch?

diff --git a/setup.py b/setup.py
index e9aea74..a365192 100644
--- a/setup.py
+++ b/setup.py
@@ -23,7 +23,6 @@ import sys
 import subprocess
 import time
 import io
-import six
 from contextlib import contextmanager
 
 join = os.path.join
@@ -202,10 +201,7 @@ def stdout_redirected(new_stdout='install.log'):
         # Point original_stdout_fid to to_fid
         os.dup2(to_fid,original_stdout_fid)
         # Create sys.stdout
-        if six.PY3:
-            sys.stdout = io.TextIOWrapper(os.fdopen(original_stdout_fid,'wb'))
-        else:    
-            sys.stdout = os.fdopen(original_stdout_fid,'wb')
+        sys.stdout = io.TextIOWrapper(os.fdopen(original_stdout_fid,'wb'))
 
     try:
         _redirect(install_log_file_fid)
@ketch
Copy link
Member

ketch commented Mar 6, 2024

#245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants